Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to using an rclpy context manager. #787

Merged
merged 1 commit into from
Jul 9, 2024
Merged

Switch to using an rclpy context manager. #787

merged 1 commit into from
Jul 9, 2024

Conversation

clalancette
Copy link
Contributor

This still manages the lifetime of rclpy, but uses less code to do so.

This is part of ros2/rclpy#1280

@clalancette
Switch to using an rclpy context manager.
cbc5bf9 
This still manages the lifetime of rclpy, but uses
less code to do so.

Signed-off-by: Chris Lalancette <clalancette@gmail.com>
@clalancette clalancette requested a review from sloretz July 9, 2024 18:38
@clalancette
Copy link
Contributor Author

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@clalancette clalancette merged commit 600119f into rolling Jul 9, 2024
3 checks passed
@clalancette clalancette deleted the clalancette/rclpy-use-context-manager branch July 9, 2024 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sloretz sloretz sloretz approved these changes

@adityapande-1995 adityapande-1995 Awaiting requested review from adityapande-1995 adityapande-1995 is a code owner

@methylDragon methylDragon Awaiting requested review from methylDragon methylDragon is a code owner

@wjwwood wjwwood Awaiting requested review from wjwwood wjwwood is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@clalancette @sloretz